lkml.org 
[lkml]   [2012]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/40] autonuma: define the autonuma flags
On 06/28/2012 08:55 AM, Andrea Arcangeli wrote:
> These flags are the ones tweaked through sysfs, they control the
> behavior of autonuma, from enabling disabling it, to selecting various
> runtime options.

That's all fine and dandy, but what do these flags mean?

How do you expect people to be able to maintain this code,
or control autonuma behaviour, when these flags are not
documented at all?

Please document them.

> +enum autonuma_flag {
> + AUTONUMA_FLAG,
> + AUTONUMA_IMPOSSIBLE_FLAG,
> + AUTONUMA_DEBUG_FLAG,
> + AUTONUMA_SCHED_LOAD_BALANCE_STRICT_FLAG,
> + AUTONUMA_SCHED_CLONE_RESET_FLAG,
> + AUTONUMA_SCHED_FORK_RESET_FLAG,
> + AUTONUMA_SCAN_PMD_FLAG,
> + AUTONUMA_SCAN_USE_WORKING_SET_FLAG,
> + AUTONUMA_MIGRATE_DEFER_FLAG,
> +};


--
All rights reversed


\
 
 \ /
  Last update: 2012-06-29 19:42    [W:0.526 / U:0.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site