lkml.org 
[lkml]   [2012]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/5] powerpc/85xx: implement hardware timebase sync
On 06/29/2012 10:39 AM, Tabi Timur-B04825 wrote:
> On Tue, Jun 26, 2012 at 5:25 AM, Zhao Chenhui
> <chenhui.zhao@freescale.com> wrote:
>> +static void mpc85xx_give_timebase(void)
>> +{
>> + unsigned long flags;
>> +
>> + local_irq_save(flags);
>> +
>> + while (!tb_req)
>> + barrier();
>
> I think tb_req and tb_valid need to be 'volatile'.

No, barrier() and mb() take care of that.

>> +static const struct of_device_id mpc85xx_smp_guts_ids[] = {
>> + { .compatible = "fsl,mpc8572-guts", },
>> + { .compatible = "fsl,p1020-guts", },
>> + { .compatible = "fsl,p1021-guts", },
>> + { .compatible = "fsl,p1022-guts", },
>> + { .compatible = "fsl,p1023-guts", },
>> + { .compatible = "fsl,p2020-guts", },
>> + {},
>> +};
>
> I wonder if it's possible to dynamically generate the compatible
> string by using the SOC name?

Where are you going to get the SoC name from?

-Scott



\
 
 \ /
  Last update: 2012-06-29 18:41    [W:0.207 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site