Messages in this thread | | | Subject | Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions | From | Alex Williamson <> | Date | Fri, 29 Jun 2012 09:14:33 -0600 |
| |
On Thu, 2012-06-28 at 11:38 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2012 23:09:04 -0600 > > Alex Williamson <alex.williamson@redhat.com> wrote: > > > > > Prune this down to just the struct kvm_irqfd so we can avoid > > > changing function definition for every flag or field we use. > > > > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > > > > I'm currently trying to find a way to make irqfd workable for s390 > > which will likely include using a new field in kvm_irqfd, so I'd like > > to have this change (and I also think it makes the code nicer to read). > > So: > > > > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> > > Unfortunately it looks like we are not sanitizing kvm_irqfd > at all so we won't be able to use the padding :( > We'll need a new ioctl instead.
I think you're jumping the gun on this decision.
| |