Messages in this thread | | | Date | Fri, 29 Jun 2012 15:16:54 +0200 | From | Clemens Ladisch <> | Subject | Re: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls |
| |
Marek Szyprowski wrote: > On Friday, June 29, 2012 1:10 PM Clemens Ladisch wrote: >> Marek Szyprowski wrote: >>> +++ b/drivers/base/dma-mapping.c >>> ... >>> +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, >>> + void *cpu_addr, dma_addr_t dma_addr, size_t size) >>> +{ >>> + int ret = -ENXIO; >>> + ... >>> + if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, &ret)) >>> + return ret; >> >> This will return -ENXIO if dma_mmap_from_coherent() succeeds. > > Thanks for spotting this!
Sorry, I was wrong; ret is actually set by dma_mmap_from_coherent's output parameter. (That function's documentation appears to be incomplete.)
Regards, Clemens
| |