Messages in this thread | | | Date | Thu, 28 Jun 2012 16:01:02 +0900 | From | Yasuaki Ishimatsu <> | Subject | Re: [RFC PATCH 2/12] memory-hogplug : check memory offline in offline_pages |
| |
Hi David,
2012/06/27 15:16, David Rientjes wrote: > On Wed, 27 Jun 2012, Yasuaki Ishimatsu wrote: > >> Index: linux-3.5-rc4/mm/memory_hotplug.c >> =================================================================== >> --- linux-3.5-rc4.orig/mm/memory_hotplug.c 2012-06-26 13:28:16.743211538 +0900 >> +++ linux-3.5-rc4/mm/memory_hotplug.c 2012-06-26 13:48:38.264940468 +0900 >> @@ -887,6 +887,11 @@ static int __ref offline_pages(unsigned >> >> lock_memory_hotplug(); >> >> + if (memory_is_offline(start_pfn, end_pfn)) { >> + ret = 0; >> + goto out; >> + } >> + >> zone = page_zone(pfn_to_page(start_pfn)); >> node = zone_to_nid(zone); >> nr_pages = end_pfn - start_pfn; > > Are there additional prerequisites for this patch? Otherwise it changes > the return value of offline_memory() which will now call > acpi_memory_powerdown_device() in the acpi memhotplug case when disabling. > Is that a problem?
I have understood there is a person who expects "offline_pages()" to fail in this case by kosaki's comment. So I'll move memory_is_offline to caller side.
Thanks, Yasuaki Ishimatsu
> > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
| |