Messages in this thread Patch in this message | | | Date | Thu, 28 Jun 2012 09:45:26 +0300 | From | Dan Carpenter <> | Subject | [patch 3/3] vfio: return -EFAULT on failure |
| |
This ioctl function is supposed to return a negative error code or zero on success. copy_to_user() returns zero or the number of bytes remaining to be copied.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 457acf3..1aa373f 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1159,6 +1159,8 @@ static long vfio_group_fops_unl_ioctl(struct file *filep, status.flags |= VFIO_GROUP_FLAGS_CONTAINER_SET; ret = copy_to_user((void __user *)arg, &status, minsz); + if (ret) + ret = -EFAULT; break; }
| |