[lkml]   [2012]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: memcg: cat: memory.memsw.* : Operation not supported
    Hello, Michal.

    On Thu, Jun 28, 2012 at 02:36:11PM +0200, Michal Hocko wrote:
    > @@ -2726,6 +2726,9 @@ static int cgroup_addrm_files(struct cgroup *cgrp, struct cgroup_subsys *subsys,
    > int err, ret = 0;
    > for (cft = cfts; cft->name[0] != '\0'; cft++) {
    > + if (subsys->cftype_enabled && !subsys->cftype_enabled(cft->name))
    > + continue;
    > +
    > if (is_add)
    > err = cgroup_add_file(cgrp, subsys, cft);
    > else

    I hope we could avoid this dynamic decision. That was one of the main
    reasons behind doing the cftype thing. It's better to be able to
    "declare" these kind of things rather than being able to implement
    fully flexible dynamic logic. Too much flexibility often doesn't
    achieve much while being a hindrance to evolution of code base (trying
    to improve / simplify X - ooh... there's this single wacko corner case
    YYY here which is really different from all other users).

    really_do_swap_account can't change once booted, right? Why not just
    separate out memsw cfts into a separate array and call
    cgroup_add_cftypes() from init path? Can't we do that from



     \ /
      Last update: 2012-06-28 20:41    [W:0.024 / U:2.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site