Messages in this thread | | | Date | Thu, 28 Jun 2012 10:15:28 -0500 | From | Seth Forshee <> | Subject | Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building |
| |
On Thu, Jun 28, 2012 at 07:21:11PM +0530, Arun Raghavan wrote: > I missed the stubs, so the patch should probably just be adding this > line: > > depends on APPLE_BACKLIGHT = n || APPLE_BACKLIGHT > > but that conflicts with the 'select BACKLIGHT_CLASS_DEVICE' (a recursive > dependency is detected).
Sigh. We have a similar situation with acpi_video, which undoubtedly also affects some other drivers as well.
This is the best I've been able to come up with.
depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE depends on ACPI_VIDEO=n || ACPI_VIDEO
This at least keeps it from being built-in if it's going to be linking against symbols provided by a module. I'm definitely open to other suggestions though.
Seth
| |