lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/16] netvm: Allow skb allocation to use PFMEMALLOC reserves
On Tue, Jun 26, 2012 at 05:27:34PM +0200, Sebastian Andrzej Siewior wrote:
> On Fri, Jun 22, 2012 at 03:30:36PM +0100, Mel Gorman wrote:
> > diff --git a/net/core/sock.c b/net/core/sock.c
> > index 5c9ca2b..159dccc 100644
> > --- a/net/core/sock.c
> > +++ b/net/core/sock.c
> > @@ -271,6 +271,9 @@ __u32 sysctl_rmem_default __read_mostly = SK_RMEM_MAX;
> > int sysctl_optmem_max __read_mostly = sizeof(unsigned long)*(2*UIO_MAXIOV+512);
> > EXPORT_SYMBOL(sysctl_optmem_max);
> >
> > +struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE;
> > +EXPORT_SYMBOL_GPL(memalloc_socks);
> > +
>
> This is used via sk_memalloc_socks() by SLAB.
>
> From 3da9ab9972845974da114c5a6624335e6371b2d5 Mon Sep 17 00:00:00 2001
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Date: Tue, 26 Jun 2012 17:18:20 +0200
> Subject: [PATCH] export sk_memalloc_socks() only with CONFIG_NET
>
> |mm/built-in.o: In function `atomic_read':
> |include/asm/atomic.h:25: undefined reference to `memalloc_socks'
> |include/asm/atomic.h:25: undefined reference to `memalloc_socks'
> |include/asm/atomic.h:25: undefined reference to `memalloc_socks'
> |include/asm/atomic.h:25: undefined reference to `memalloc_socks'
> |include/asm/atomic.h:25: undefined reference to `memalloc_socks'
> |mm/built-in.o:include/asm/atomic.h:25: more undefined references to `memalloc_socks' follow
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Well caught. I had not tested build with !CONFIG_NET. I've folded in
this patch and the credits accordingly. Thanks.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2012-06-27 11:21    [W:4.050 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site