Messages in this thread | | | Date | Wed, 27 Jun 2012 15:36:55 -0700 | Subject | Re: [patch -resend] [SCSI] megaraid: remove a spurious IRQ enable | From | adam radford <> |
| |
On Wed, Jun 27, 2012 at 2:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > We took this lock with spin_lock() so we should unlock it with > spin_unlock() instead of spin_unlock_irq(). This was introduced in > f2c8dc402b "[SCSI] megaraid_mbox: remove scsi_assign_lock usage". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > This was originally sent on Sat, 30 Jul 2011. I have cleaned up the > commit message a bit and added Christoph to the CC list. > > diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c > index 35bd138..54b1c5b 100644 > --- a/drivers/scsi/megaraid/megaraid_mbox.c > +++ b/drivers/scsi/megaraid/megaraid_mbox.c > @@ -2731,7 +2731,7 @@ megaraid_reset_handler(struct scsi_cmnd *scp) > } > > out: > - spin_unlock_irq(&adapter->lock); > + spin_unlock(&adapter->lock); > return rval; > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Adam Radford <aradford@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |