lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/7] tracing/function: Introduce persistent trace option
From
Date
On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:
>
> @@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int set)
>
> return 0;
> }
> + if (bit == TRACE_FUNC_OPT_PSTORE)
> + return 0;

Perhaps this should be a switch() statement, or at least put a
} else if () {

As it can't be bit == TRACE_FUNC_OPT_STACK and bit ==
TRACE_FUNC_OPT_PSTORE.

-- Steve

>
> return -EINVAL;
> }




\
 
 \ /
  Last update: 2012-06-27 15:21    [W:1.457 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site