Messages in this thread | | | Date | Wed, 27 Jun 2012 13:00:20 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx |
| |
On 06/27/2012 12:59 PM, Michal Hocko wrote: > On Wed 27-06-12 12:43:50, Glauber Costa wrote: >> On 06/27/2012 04:16 AM, Wanpeng Li wrote: >>> From: Wanpeng Li <liwp@linux.vnet.ibm.com> >>> >>> Changelog: >>> >>> V2 -> V1: >>> >>> * replace memory_cgroup_xxx by memcg_xxx >>> >>> Unify memcg functions to memcg_xxx. >> >> >> This patch achieves nothing. >> You're changing a couple of function names. Andrew stated goal was >> to change *all* function names from mem_cgroup_xxx to memcg_xxx, not >> just one or two. > > No mass things now, please. > git grep mem_cgroup_ mm/ include/ | wc -l > 863 > > This will be real pain for merging. > It's either that, or I have my new functions named memcg_ and we live with the inconsistency.
Point is, changing one function name as he did, achieves nothing.
| |