Messages in this thread | | | Date | Mon, 25 Jun 2012 21:11:55 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 03/11] memcg: change defines to an enum |
| |
On Mon, 25 Jun 2012, Glauber Costa wrote:
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 8e601e8..9352d40 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -387,9 +387,12 @@ enum charge_type { > }; > > /* for encoding cft->private value on file */ > -#define _MEM (0) > -#define _MEMSWAP (1) > -#define _OOM_TYPE (2) > +enum res_type { > + _MEM, > + _MEMSWAP, > + _OOM_TYPE, > +}; > + > #define MEMFILE_PRIVATE(x, val) ((x) << 16 | (val)) > #define MEMFILE_TYPE(val) ((val) >> 16 & 0xffff) > #define MEMFILE_ATTR(val) ((val) & 0xffff)
Shouldn't everything that does MEMFILE_TYPE() now be using type enum res_type rather than int?
| |