lkml.org 
[lkml]   [2012]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/11] memcg: change defines to an enum
    On Mon, 25 Jun 2012, Glauber Costa wrote:

    > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    > index 8e601e8..9352d40 100644
    > --- a/mm/memcontrol.c
    > +++ b/mm/memcontrol.c
    > @@ -387,9 +387,12 @@ enum charge_type {
    > };
    >
    > /* for encoding cft->private value on file */
    > -#define _MEM (0)
    > -#define _MEMSWAP (1)
    > -#define _OOM_TYPE (2)
    > +enum res_type {
    > + _MEM,
    > + _MEMSWAP,
    > + _OOM_TYPE,
    > +};
    > +
    > #define MEMFILE_PRIVATE(x, val) ((x) << 16 | (val))
    > #define MEMFILE_TYPE(val) ((val) >> 16 & 0xffff)
    > #define MEMFILE_ATTR(val) ((val) & 0xffff)

    Shouldn't everything that does MEMFILE_TYPE() now be using type
    enum res_type rather than int?


    \
     
     \ /
      Last update: 2012-06-26 06:43    [W:0.022 / U:92.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site