Messages in this thread | | | Date | Tue, 26 Jun 2012 22:45:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 2/2] x86 mce: use new printk recursion disabling interface |
| |
On Fri, Jun 22, 2012 at 04:41:43PM -0700, Andrew Morton wrote: > A couple of things here. > > a) mce_panic() has a "return" statement deep inside. So we return > from mce_panic() with the recursion check disabled. whoops.
Yeah, you're staring at v4 and we fixed this later (currently discussing v7, please follow this thread :))
> b) adding a nice comment is nice.
Agreed, if the actual use case pans out and we really need this interface...
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |