Messages in this thread | | | Date | Mon, 25 Jun 2012 12:20:07 -0700 | From | Greg KH <> | Subject | Re: [PATCH] syslog: fill buffer with more than a single message for SYSLOG_ACTION_READ |
| |
On Mon, Jun 25, 2012 at 08:05:17AM +0100, Jan Beulich wrote: > >>> On 23.06.12 at 20:03, Kay Sievers <kay@vrfy.org> wrote: > >> Furthermore, this patch also addresses the problem dealt with in > >> commit 4a77a5a06ec66ed05199b301e7c25f42f979afdc ("printk: use mutex > >> lock to stop syslog_seq from going wild"), so I'd recommend reverting > >> that one too (albeit there's no direct collision between the two). > > > > Are you sure that is covered? Doesn't the other thread would just > > return 0 to the caller then, instead of continuing to stay in the > > syscall when the first thread got the message? > > The old code permitted returning zero in that case too, so I don't > see why the new code shouldn't be allowed to. But anyway, as > said this patch doesn't directly conflict, and hence it's up to the > maintainer(s) of the code to decide whether to keep it. The > conflicting one, however, imo ought to be reverted in any case.
Ok, so I'm confused, you want me to apply this patch and then revert a different one? Which one, 4a77a5a06ec66ed05199b301e7c25f42f979afdc?
Kay, do you agree?
thanks,
greg k-h
| |