lkml.org 
[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] memcg: cleanup useless LRU_ALL_EVICTABLE
(2012/06/25 18:33), Michal Hocko wrote:
> Marking this patch as memcg is quite misleading. mm is more suitable.
>
> On Mon 25-06-12 16:43:32, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>> Since LRU_ALL_EVICTABLE is useless, just remove it.
>
> It's really strange but I do not see any usage of this except for it's
> introduction. So agreed to remove it.
>
>> Add LRU_ALL_UNEVICTABLE to mask unevictable pages.
>
> Does it really make sense to introduce just for two uses in a single
> function?
>

I don't think so.

I doubt LRU_ALL_UNEVICTABLE implies there are other UNEVICTABLE LRUS
other than LRU_UNEVICTABLE.

For example, LRU_ALL_UNEVICTABLE means
if total_swap==0, UNEVICTABLE+ANON
if total_swap!=0, UNEVICTABLE,

This will have its own meanings...but I don't see there are any users.

Thanks,
-Kame




\
 
 \ /
  Last update: 2012-06-25 12:41    [W:0.500 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site