lkml.org 
[lkml]   [2012]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BUG: tracer_alloc_buffers returned with preemption imbalance
On Sun, Jun 24, 2012 at 01:48:30AM +0800, Fengguang Wu wrote:
> > > static inline int rcu_blocking_is_gp(void)
> > > {
> > > might_sleep(); /* Check for RCU read-side critical section. */
> > > + preempt_disable();
> > > return num_online_cpus() <= 1;
> > > + preempt_enable();
> > > }
> >
> > Thank you! I have no idea how a preempt_disable() causes that badness
> > to happen, but this commit is not yet critically important, so I will
> > drop it.
>
> preempt_enable() becomes dead code because of the return statement?
> I wonder why gcc didn't issue a warning (or I failed to catch it)...

Color me blind and stupid!!! Thank you, will fix.

Thanx, Paul



\
 
 \ /
  Last update: 2012-06-23 23:01    [W:0.053 / U:6.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site