Messages in this thread | | | Date | Sat, 23 Jun 2012 18:18:19 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/2] staging: zram: Remove useless struct zobj_header |
| |
On Thu, Jun 21, 2012 at 12:32:45AM -0300, Marcos Paulo de Souza wrote: > The struct zobj_header has no members, so the sizeof(struct zobj_header *) > always returns zero. For this reason we are removing this useless struct. >
I've been out for the past few days and I'm slowly catching up. If you want you could update this comment as well:
drivers/staging/zram/zram_drv.h 40 /* 41 * NOTE: max_zpage_size must be less than or equal to: 42 * ZS_MAX_ALLOC_SIZE - sizeof(struct zobj_header) 43 * otherwise, xv_malloc() would always return failure. 44 */
regards, dan carpenter
| |