lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpuidle: move field disable from per-driver to per-cpu
On Thu, 14 Jun 2012 10:52:48 +0800
ShuoX Liu <shuox.liu@intel.com> wrote:

> From: ShuoX Liu <shuox.liu@intel.com>
>
> Andrew J.Schorr raises a question. When he changes the disable setting
> on a single CPU, it affects all the other CPUs. Basically, currently,
> the disable field is per-driver instead of per-cpu. All the C states of
> the same driver are shared by all CPU in the same machine.
>
> Below patch changes field disable to per-cpu, so we could set this
> separately for each cpu.
>
> ...
>
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -34,6 +34,7 @@ struct cpuidle_driver;
> struct cpuidle_state_usage {
> void *driver_data;
>
> + unsigned long long disable;

hrmpf. We're using 64 bits for this where one bit would do, afaict
because the magic macros in drivers/cpuidle/sysfs.c are using %llu.



\
 
 \ /
  Last update: 2012-06-23 02:01    [W:0.510 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site