Messages in this thread | | | From | Vaibhav Nagarnaik <> | Date | Fri, 22 Jun 2012 11:54:43 -0700 | Subject | Re: [PATCH] tracing: Fix crash due to uninitialized new_pages list head |
| |
On Fri, Jun 22, 2012 at 11:50 AM, Vaibhav Nagarnaik <vnagarnaik@google.com> wrote: > The new_pages list head in the cpu_buffer is not initialized. When > adding pages to the ring buffer, if the memory allocation fails in > ring_buffer_resize, the clean up handler tries to free up the allocated > pages from all the cpu buffers. The panic is caused by referencing the > uninitialized new_pages list head. > > Initializing the new_pages list head in rb_allocate_cpu_buffer fixes > this. > > Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@google.com> > ---
Hi Steven,
I believe this fix should be pushed to 3.5 along with the other patch I sent earlier: tracing: Update entries counter when removing pages
These two patches fix issues with the recently added atomic resize patches.
Thanks
Vaibhav Nagarnaik
| |