lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] REGULATOR: fix regmap offsets for enable/disable
    Date
    I forgot to apply the offsets for the regmap helper functions for
    enable/disable on SMPS10 and the LDO regulators. This means regulators
    will not enable/disable correctly.

    Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
    Tested-by: Sebastien Guiriec <s-guiriec@ti.com>
    ---
    drivers/regulator/palmas-regulator.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
    index 6c48511..7540c95 100644
    --- a/drivers/regulator/palmas-regulator.c
    +++ b/drivers/regulator/palmas-regulator.c
    @@ -667,7 +667,9 @@ static __devinit int palmas_probe(struct platform_device *pdev)
    pmic->desc[id].ops = &palmas_ops_smps10;
    pmic->desc[id].vsel_reg = PALMAS_SMPS10_CTRL;
    pmic->desc[id].vsel_mask = SMPS10_VSEL;
    - pmic->desc[id].enable_reg = PALMAS_SMPS10_STATUS;
    + pmic->desc[id].enable_reg =
    + PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE,
    + PALMAS_SMPS10_STATUS);
    pmic->desc[id].enable_mask = SMPS10_BOOST_EN;
    pmic->desc[id].min_uV = 3750000;
    pmic->desc[id].uV_step = 1250000;
    @@ -739,7 +741,8 @@ static __devinit int palmas_probe(struct platform_device *pdev)

    pmic->desc[id].type = REGULATOR_VOLTAGE;
    pmic->desc[id].owner = THIS_MODULE;
    - pmic->desc[id].enable_reg = palmas_regs_info[id].ctrl_addr;
    + pmic->desc[id].enable_reg = PALMAS_BASE_TO_REG(PALMAS_LDO_BASE,
    + palmas_regs_info[id].ctrl_addr);
    pmic->desc[id].enable_mask = PALMAS_LDO1_CTRL_MODE_ACTIVE;

    if (pdata && pdata->reg_data)
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-06-22 15:21    [W:4.732 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site