Messages in this thread | | | Date | Fri, 22 Jun 2012 14:28:07 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH 1/2] memcg: use existing function to judge root mem cgroup |
| |
On Fri 22-06-12 19:57:22, Wanpeng Li wrote: > From: Wanpeng Li <liwp@linux.vnet.ibm.com> > > Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index f72b5e5..776fc57 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4873,7 +4873,7 @@ mem_cgroup_create(struct cgroup *cont) > goto free_out; > > /* root ? */ > - if (cont->parent == NULL) { > + if (!(mem_cgroup_is_root(cont))) {
This is not correct. mem_cgroup_is_root takes mem_cgroup and you are giving it cgroup, see?
> int cpu; > enable_swap_cgroup(); > parent = NULL; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |