lkml.org 
[lkml]   [2012]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip
    On Fri, Jun 22, 2012 at 9:05 AM, Kim, Milo <Milo.Kim@ti.com> wrote:
    >> LM3556 :
    >> The LM3556 is a 4 MHz fixed-frequency synchronous boost
    >> converter plus 1.5A constant current driver for a high-current white
    >> LED.
    >
    > Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use.
    >
    > Just one thing to be better,
    > I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity.
    >

    Hi G.Shark,

    I also think this patch is good enough for merging now after your
    fixed several issues pointed out by Axel Lin.
    I fixed this module_i2c_driver() issue mentioned by Milo here and push
    it to my -devel branch.
    If there is no problem, I will applied it to for-next branch.

    Thanks,
    -Bryan

    >> +static int __init lm3556_init(void)
    >> +{
    >> +     return i2c_add_driver(&lm3556_i2c_driver);
    >> +}
    >> +
    >> +static void __exit lm3556_exit(void)
    >> +{
    >> +     i2c_del_driver(&lm3556_i2c_driver);
    >> +}
    >> +
    >> +module_init(lm3556_init);
    >> +module_exit(lm3556_exit);
    >
    > module_i2c_driver(lm3556_i2c_driver);
    >
    > Thanks,
    > Milo -



    --
    Bryan Wu <bryan.wu@canonical.com>
    Kernel Developer    +86.186-168-78255 Mobile
    Canonical Ltd.      www.canonical.com
    Ubuntu - Linux for human beings | www.ubuntu.com
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-22 06:01    [W:0.034 / U:29.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site