lkml.org 
[lkml]   [2012]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip
Date
> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white
> LED.

Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use.

Just one thing to be better,
I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity.

> +static int __init lm3556_init(void)
> +{
> + return i2c_add_driver(&lm3556_i2c_driver);
> +}
> +
> +static void __exit lm3556_exit(void)
> +{
> + i2c_del_driver(&lm3556_i2c_driver);
> +}
> +
> +module_init(lm3556_init);
> +module_exit(lm3556_exit);

module_i2c_driver(lm3556_i2c_driver);

Thanks,
Milo -


\
 
 \ /
  Last update: 2012-06-22 03:41    [W:0.069 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site