Messages in this thread | | | Date | Thu, 21 Jun 2012 00:57:55 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 1/5] iommu/tegra: smmu: Add DMA window parser, of_get_dma_window() |
| |
On 06/21/2012 12:46 AM, Hiroshi Doyu wrote: ... > There are the following 3 users of of_parse_dma_window() as below. All > of them are IOMMU related, but they are architecture specific ones, > not for the standard IOMMU API. I guess that the current trend is to > convert Arch specific IOMMU API to the standard one basically. > > arch/powerpc/kernel/vio.c of_parse_dma_window(dev->dev.of_node, dma_window, > arch/powerpc/platforms/cell/iommu.c of_parse_dma_window(np, dma_window, &index, base, size); > arch/powerpc/platforms/pseries/iommu.c of_parse_dma_window(dn, dma_window, &tbl->it_index, &offset, &size); > > I think that the common "dma-window" DT parser is necessary for the > standard IOMMU because "dma-window" info is dealt as > DOMAIN_ATTR_GEOMETRY in the following Joerg's patch too. > > [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware > https://lkml.org/lkml/2012/1/19/170 > > If it's ok to have of_get_dma_window() in "drivers/iommu/of_iommu.c", > I'll post that version.
Sounds sane to me.
| |