lkml.org 
[lkml]   [2012]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/9] PCI: Remove redundant debug output in pci_do_fixups
Date
When the boot argument 'initcall_debug' is specified, redundant debug
output occurs for each device as a quirk is applied:
...
pci 0000:00:1a.0: calling quirk_usb_early_handoff+0x0/0x620
calling quirk_usb_early_handoff+0x0/0x620 @ 1 for 0000:00:1a.0
pci fixup quirk_usb_early_handoff+0x0/0x620 returned after 32 usecs for 0000:00: 1a.0
...

This patch removes the redundancy by eliminating the first debug output
occurence in the sequence shown above when 'initcall_debug' is specified.

Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
---

drivers/pci/quirks.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a2d9d33..9c93558 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2953,11 +2953,12 @@ static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
f->vendor == (u16) PCI_ANY_ID) &&
(f->device == dev->device ||
f->device == (u16) PCI_ANY_ID)) {
- dev_dbg(&dev->dev, "calling %pF\n", f->hook);
if (initcall_debug)
do_one_fixup_debug(f->hook, dev);
- else
+ else {
+ dev_dbg(&dev->dev, "calling %pF\n", f->hook);
f->hook(dev);
+ }
}
}



\
 
 \ /
  Last update: 2012-06-21 23:01    [W:0.083 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site