Messages in this thread | | | Date | Thu, 21 Jun 2012 08:55:43 -0300 | Subject | Re: [PATCH] SPI: at25: Parse dt settings | From | Alexandre Pereira da Silva <> |
| |
On Thu, Jun 21, 2012 at 8:10 AM, Alexandre Pereira da Silva <aletes.xgr@gmail.com> wrote: > On Thu, Jun 21, 2012 at 6:49 AM, Ivo Sieben <meltedpianoman@gmail.com> wrote: >> One small remark: >> In case of platform_data, the "if (!chip)" check has been removed and >> is now only handled in the device tree initialization. >> Maybe add this check to the platform initialization as well: >> >> } else { >> if (!spi->dev.platform_data) { >> dev_dbg(&spi->dev, "no chip description\n"); >> err = -ENODEV; >> goto fail; >> } >> chip = *(struct spi_eeprom *)spi->dev.platform_data; >> }
Please ignore my last email. Not enough coffee.
I'm sorry. The code looks right to me.
- chip = spi->dev.platform_data; - if (!chip) { - dev_dbg(&spi->dev, "no chip description\n"); - err = -ENODEV; - goto fail; - } + if (!spi->dev.platform_data) { + if (np) { /* No platform data and DT node present, DT handling */ + } else { /* No DT and No platform description, handle error */ + dev_dbg(&spi->dev, "no chip description\n"); + err = -ENODEV; + goto fail; + } + } else /* At this point chip is guaranteed to have valid data */ + chip = *(struct spi_eeprom *)spi->dev.platform_data; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |