Messages in this thread | | | Date | Wed, 20 Jun 2012 08:38:05 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 02.5] mm: sl[au]b: first remove PFMEMALLOC flag then SLAB flag |
| |
On Fri, Jun 15, 2012 at 05:54:32PM +0200, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > If we first remove the SLAB flag followed by the PFMEMALLOC flag then the > removal of the latter will trigger the VM_BUG_ON() as it can be seen in > | kernel BUG at include/linux/page-flags.h:474! > | invalid opcode: 0000 [#1] PREEMPT SMP > | Call Trace: > | [<c10e2d77>] slab_destroy+0x27/0x70 > | [<c10e3285>] drain_freelist+0x55/0x90 > | [<c10e344e>] __cache_shrink+0x6e/0x90 > | [<c14e3211>] ? acpi_sleep_init+0xcf/0xcf > | [<c10e349d>] kmem_cache_shrink+0x2d/0x40 > > because the SLAB flag is gone. This patch simply changes the order. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Grr, yes of course. Thanks very much. I've folded this into patch 2 and preserved credit.
-- Mel Gorman SUSE Labs
| |