lkml.org 
[lkml]   [2012]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] Docs: printk-formats: add description for %pMR
    On Wed, 20 Jun 2012 13:44:49 +0300
    Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> wrote:

    > From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
    >
    > Add information about new specifier %pMR for Bluetooth addresses.
    >
    > ...
    >
    > --- a/Documentation/printk-formats.txt
    > +++ b/Documentation/printk-formats.txt
    > @@ -56,6 +56,7 @@ Struct Resources:
    > MAC/FDDI addresses:
    >
    > %pM 00:01:02:03:04:05
    > + %pMR 05:04:03:02:01:00
    > %pMF 00-01-02-03-04-05
    > %pm 000102030405
    >
    > @@ -67,6 +68,10 @@ MAC/FDDI addresses:
    > the 'M' specifier to use dash ('-') separators instead of the default
    > separator.
    >
    > + For Bluetooth addresses the 'R' specifier shall be used after the 'M'
    > + specifier to use reversed byte order suitable for visual interpretation
    > + of Bluetooth addresses which are in the little endian order.
    > +

    huh, I didn't know about that file, or I forgot about it. I wonder if
    it is otherwise up to date.

    Do we really need it? If we can sufficiently document the printk
    formats in lib/vsprintf.c then let's remove
    Documentation/printk-formats.txt. Otherwise, I shall do this:


    --- a/lib/vsprintf.c
    +++ a/lib/vsprintf.c
    @@ -1297,6 +1297,8 @@ qualifier:
    * case.
    * %n is ignored
    *
    + * ** Please update Documentation/printk-formats.txt when making changes **
    + *
    * The return value is the number of characters which would
    * be generated for the given input, excluding the trailing
    * '\0', as per ISO C99. If you want to have the exact
    _


    \
     
     \ /
      Last update: 2012-06-21 00:01    [W:4.482 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site