Messages in this thread | | | Date | Wed, 20 Jun 2012 23:31:41 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] GPIOLIB: add generic gpio_set_pull API |
| |
On Wed, Jun 20, 2012 at 10:15:01AM +0200, Linus Walleij wrote: > On Tue, Jun 19, 2012 at 5:25 AM, Barry Song <21cnbao@gmail.com> wrote: > > but i think at least the macros of GPIO_PULL_NONE, GPIO_PULL_UP and > > GPIO_PULL_DOWN should be standardized. > > You find an attempt at standardization in drivers/pinctrl/pinconf-generic.c > which is also used by the composite U300+COH901 drivers. Drivers > can select this support library and use the flags from > <linux/pinctrl/pinconf-generic.h> > What's with PIN_CONFIG_END using such an insane value?
I'm happy to consolidate on the provided definitions and add my own on top of that, but I'm not going to waste an insane amount of bits that I could be using for driver-specific data and so on instead to comply with the PIN_CONFIG_END comment. Is there any valid reason why this would ever need to exceed 4 bits?
| |