Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Wed, 20 Jun 2012 01:01:25 -0400 | Subject | Re: [PATCH] mm, fadvise: don't return -EINVAL when filesystem has no optimization way |
| |
On Fri, Jun 15, 2012 at 4:36 PM, <kosaki.motohiro@gmail.com> wrote: > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Eric Wong reported his test suite was fail when /tmp is tmpfs. > > https://lkml.org/lkml/2012/2/24/479 > > Current,input check of POSIX_FADV_WILLNEED has two problems. > > 1) require a_ops->readpage. > But in fact, force_page_cache_readahead() only require > a target filesystem has either ->readpage or ->readpages. > 2) return -EINVAL when filesystem don't have ->readpage. > But, posix says, it should be retrieved a hint. Thus fadvise() > should return 0 if filesystem has no optimization way. > Especially, userland application don't know a filesystem type > of TMPDIR directory as Eric pointed out. Then, userland can't > avoid this error. We shouldn't encourage to ignore syscall > return value. > > Thus, this patch change a return value to 0 when filesytem don't > support readahead. > > Cc: linux-mm@kvack.org > Cc: Hugh Dickins <hughd@google.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Hillf Danton <dhillf@gmail.com> > Signed-off-by: Eric Wong <normalperson@yhbt.net> > Tested-by: Eric Wong <normalperson@yhbt.net> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > ---
no objection? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |