lkml.org 
[lkml]   [2012]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] h8300/uaccess: Remove assignment to __gu_val in unhandled case of get_user()
    Date
    __gu_val is const if the passed ptr is const, giving:

    include/linux/pagemap.h: In function 'fault_in_pages_readable':
    include/linux/pagemap.h:442:2: error: assignment of read-only variable '__gu_val'
    include/linux/pagemap.h:448:4: error: assignment of read-only variable '__gu_val'
    include/linux/pagemap.h: In function 'fault_in_multipages_readable':
    include/linux/pagemap.h:499:3: error: assignment of read-only variable '__gu_val'
    include/linux/pagemap.h:508:3: error: assignment of read-only variable '__gu_val'
    make[4]: *** [init/main.o] Error 1

    As we don't care about the actual value of __gu_val in the unhandled
    case (it will cause a link error anyway), just remove the assignment.

    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    ---
    arch/h8300/include/asm/uaccess.h | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/arch/h8300/include/asm/uaccess.h b/arch/h8300/include/asm/uaccess.h
    index 356068c..534394f 100644
    --- a/arch/h8300/include/asm/uaccess.h
    +++ b/arch/h8300/include/asm/uaccess.h
    @@ -100,7 +100,6 @@ extern int __put_user_bad(void);
    break; \
    default: \
    __gu_err = __get_user_bad(); \
    - __gu_val = 0; \
    break; \
    } \
    (x) = __gu_val; \
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2012-06-02 22:41    [W:0.021 / U:9.584 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site