Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 2 Jun 2012 16:14:57 -0700 | Subject | Re: [PATCH] tty: add lockdep annotations |
| |
On Sat, Jun 2, 2012 at 4:02 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > per ldisc waitqueue is indeed independent. The rest I'll try and check > but may be Wednesday for a serious check. You could also I guess narrow > the check by leaving it all passing tty in to the lock function but just > using the global lock. Might keep the noise down for the 3.6 work too.
Not really possible. The bug fundamentally comes from how the per-tty locking locks too late - after the lookup - rather than before.
And fixing that to lock in the right place is not possible with the "pass in the tty" model. Because we don't know what the tty will be.
Linus
| |