lkml.org 
[lkml]   [2012]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] zcache: fix preemptable memory allocation in atomic context
On 06/19/2012 03:32 AM, Xiao Guangrong wrote:

> zcache_do_preload uses ZCACHE_GFP_MASK to allocate memory that will be sleep,
> but zcache_do_preload is called in zcache_put_page where IRQ is disabled
>
> Fix it by use GFP_ATOMIC flag


Did you get a might_sleep warning on this? I haven't seen this being an
issue.

GFP_ATOMIC only modifies the existing mask to allow allocation use the
emergency pool. It is __GFP_WAIT not being set that prevents sleep. We
don't want to use the emergency pool since we make large, long lived
allocations with this mask.

--
Seth



\
 
 \ /
  Last update: 2012-06-19 17:01    [W:0.138 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site