Messages in this thread | | | Date | Tue, 19 Jun 2012 17:36:09 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 1/2] regulator: support for regulator match by regulator-compatible |
| |
On Tuesday 19 June 2012 04:13 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Jun 19, 2012 at 03:04:00PM +0530, Laxman Dewangan wrote: > >> Agree. Currently following regulators are using this (based on grep) >> mfd/tps6586x.c >> regulator/ab8500.c >> regulator/db8500-prcmu.c >> and regulator/tps65910. > > I've no concerns with the interface or the code itself other than the > usability issue with partial deployment so if you could do the updates > for the other drivers that'd be great. I'll hold off on applying this > until we've got everything else updated.
Mark, Just thinking on optimizing the changes require, we can do it in 3 patches only: - In place of adding new api of_regulator_match_by_compatible(), we can modify the existing of_regulator_match() itself to look for regulator-compatible for matching. This can be done in first patch. - Need not to change the .c files, here just change the documentation of these regulator dt binding. All can be done in second patch. - Change the dts file to have this policy and seeing only on arm/boot/dts/db8500.dtsi for ab8500 and db8500-prcmu. So it will be third patch .
We will not need any change on above c files as the api is not going to change.
Require your opinion.
| |