Messages in this thread | | | Date | Tue, 19 Jun 2012 10:17:49 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v3 4/6] KVM: pass slot to hva_to_pfn |
| |
On 06/18/2012 06:15 PM, Avi Kivity wrote:
> On 06/12/2012 05:48 AM, Xiao Guangrong wrote: >> This parameter will be used in the later patch >> >> >> - return hva_to_pfn(kvm, addr, atomic, async, write_fault, writable); >> + return hva_to_pfn(kvm, slot, addr, atomic, async, write_fault, >> + writable); >> } >> >> pfn_t gfn_to_pfn_atomic(struct kvm *kvm, gfn_t gfn) >> @@ -1205,7 +1210,7 @@ pfn_t gfn_to_pfn_memslot(struct kvm *kvm, >> struct kvm_memory_slot *slot, gfn_t gfn) >> { >> unsigned long addr = gfn_to_hva_memslot(slot, gfn); >> - return hva_to_pfn(kvm, addr, false, NULL, true, NULL); >> + return hva_to_pfn(kvm, slot, addr, false, NULL, true, NULL); >> } >> >> pfn_t gfn_to_pfn_memslot_atomic(struct kvm *kvm, >> @@ -1213,7 +1218,7 @@ pfn_t gfn_to_pfn_memslot_atomic(struct kvm *kvm, >> { >> unsigned long addr = gfn_to_hva_memslot(slot, gfn); >> >> - return hva_to_pfn(kvm, addr, true, NULL, true, NULL); >> + return hva_to_pfn(kvm, slot, addr, true, NULL, true, NULL); >> } > > It was unreadable before, but now it's even more unreadable.
Hmm, i will simplify hva_to_pfn() in the next version.
| |