Messages in this thread | | | Date | Tue, 19 Jun 2012 02:06:41 +0100 | From | Ken Moffat <> | Subject | Re: nfs3 problem with -rc{2,3} : blame |
| |
On Mon, Jun 18, 2012 at 11:10:52PM +0100, Ken Moffat wrote: > On Mon, Jun 18, 2012 at 10:03:24PM +0000, Myklebust, Trond wrote: > > > > Doesn't 4f97615d19 fix the fs/nfs/direct.c problem too? It should. > > > > Anyhow, if you can apply that on top of the commits that didn't compile, > > and then continue the bisection, that would be great. We definitely do > > want the !defined(CONFIG_NFS_V4) case to work in 3.5-final... > > > OK (I was assuming errors in different places were from different > causes). I'll do that after I've rerun rc3 without NFS_V4 with > SUNRPC_DEBUG. Thanks.
Bisection now points to:
6d74743b088d116e31fe1b73f47e782ee2016b94 is the first bad commit commit 6d74743b088d116e31fe1b73f47e782ee2016b94 Author: Trond Myklebust <Trond.Myklebust@netapp.com> Date: Mon Apr 30 13:27:31 2012 -0400
NFS: Simplify O_DIRECT page referencing
The O_DIRECT code shouldn't need to hold 2 references to each page. The reference held by the struct nfs_page should suffice.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: Fred Isaman <iisaman@netapp.com>
I was going to revert that from 3.5.0-rc3 to confirm that my problem with backups was gone, and then give it more extended testing to prove firefox downloads were ok, but 6 of 11 hunks failed, the code has changed and I'm not familiar with it.
So, for the moment I'm not 100% sure that this is indeed the problem.
ĸen -- das eine Mal als Tragödie, das andere Mal als Farce -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |