[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.
    >> -	if (!(htotal) || !(vtotal))
    >> - XGIFAIL("XGIfb: no valid timing data");
    >> + if (!(htotal) || !(vtotal)) {
    > Don't resend this, but next time feel free to write this like:
    > if (!htotal || !vtotal) {
    > We do have a one change per patch rule but tiny formatting things
    > like that don't count as a change.

    Sure. I'll write it down together with your other comment to my next
    round of patches ;)


    Miguel Gómez
    Igalia -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-06-18 21:01    [W:0.025 / U:16.688 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site