Messages in this thread | | | Date | Mon, 18 Jun 2012 18:30:30 +0200 (CEST) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators |
| |
On Mon, 18 Jun 2012, Mark Brown wrote:
> On Mon, Jun 18, 2012 at 05:57:24PM +0200, Guennadi Liakhovetski wrote: > > Currently regulator_register_fixed() uses a constant name to register a > > fixed dummy regulator. This is sufficient in principle, since there is no > > reason to register multiple such regulators. The user can simply supply all > > consumers in one array and use it to initialise such a regulator. However, > > in some cases it can be convenient to register multiple such regulators. > > This is also easy to achieve by appending the device ID to the name. It is > > None of this seems terribly obvious to me. Once we're getting into > allowing the user to specify a voltage (and possibly other parameters) > for the regulator it's hopefully going to refer to an actual thing we > can point at on the board rather than a virtual thing we've got to > satisfy software so giving it a useful name seems more useful (like a > name correspoding to the relevant supply on the schematic).
Sorry, don't understand. What do you mean by a "virtual" supply? There is a device, it is functional, doesn't this mean, that something is supplying power to it? And if power is supplied, then it also hopefully has a certain voltage :) Why I need to know it - to set an MMC OCR mask.
> There's also the fact that there shouldn't be any need for unique > regulator names internally so if it really doesn't matter we should be > able to give everything the same name happily enough.
What about entries under /proc/sys/debug/regulator/? Don't they have to be unique?
Thanks Guennadi
> > also consistent with the current behaviour of the code, that fixes a name > > itself without giving the user a possibility to provide a custom one. > > This is done on the basis that it's an entirely virtual regulator which > doesn't have any meaningful mapping into the hardware. If it's got a > voltage then that's no longer true. >
--- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
| |