lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.
On Mon, Jun 18, 2012 at 01:12:03PM +0200, Miguel Gómez wrote:
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1376,8 +1376,10 @@ static int XGIfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
> vtotal = var->upper_margin + var->yres + var->lower_margin
> + var->vsync_len;
>
> - if (!(htotal) || !(vtotal))
> - XGIFAIL("XGIfb: no valid timing data");
> + if (!(htotal) || !(vtotal)) {

Don't resend this, but next time feel free to write this like:

if (!htotal || !vtotal) {

We do have a one change per patch rule but tiny formatting things
like that don't count as a change.

regards,
dan carpenter

> + pr_debug("XGIfb: no valid timing data\n");
> + return -EINVAL;
> + }
>
> if (var->pixclock && htotal && vtotal) {
> drate = 1000000000 / var->pixclock;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-06-18 17:41    [W:0.089 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site