Messages in this thread | | | Date | Mon, 18 Jun 2012 17:57:55 +0530 | Subject | Re: [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free() | From | "devendra.aaru" <> |
| |
Hi,
On Mon, Jun 18, 2012 at 11:34 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > But: > >> free_group: >> - if (!purecfg) >> - free(group); >> + kfree(group); > > Why did you delete the if (!purecfg) clause? > One way we can say that as kfreeing of null doesn't affect (panic) anything and using it without purecfg may be ok.
but as the code flow says that the group is allocated only when the purecfg is not true, so i think its better to follow that way.
> Yours, > Linus Walleij
Thanks, Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |