Messages in this thread | | | Date | Mon, 18 Jun 2012 13:24:07 +0200 | From | Roland Stigge <> | Subject | Re: [PATCH] gpio: of_get_named_gpio_flags() return -EPROBE_DEFER if GPIO not yet available |
| |
On 06/18/2012 11:19 AM, Roland Stigge wrote: >> While I agree this is a correct change, it is going to break some >> existing code - at least sound/soc/tegra/tegra_{wm8903.c,alc5632.c}. > > Can you please tell in which way the patch breaks those drivers? > However, I can see that those drivers solved the same problem in a > different way (deferring of_get_named_gpio(), via the sound init()). So > they could be adjusted to take advantage of new -EPROBE_DEFER > >> However, have you audited all existing callers (including >> indirect, e.g. through plain of_get_named_gpio()) for issues this will >> cause? > > Thanks for the hint, I searched the code and found > > drivers/spi/spi-pl022.c > > to be using -ENODEV as indication to return -EPROBE_DEFER from probe(). > Will send a patch that adjusts to our of_get_named_gpio_flags() patch > and if it's good, we should join the two.
Turned out that this is a fix for a yet-unapplied patch (to support dt for pl022). Alexandre will merge my fix into his patch.
So I can't find immediate breakage from the gpiolib-of patch.
Thanks,
Roland
| |