lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: extend the fixed voltage regulator to accept voltage
On Mon, Jun 18, 2012 at 10:19:42AM +0200, Guennadi Liakhovetski wrote:

> +#define FIXED_BASE "fixed-dummy"
> +#define FIXED_NAME FIXED_BASE "-00"
> +
> struct fixed_regulator_data {
> struct fixed_voltage_config cfg;
> struct regulator_init_data init_data;
> struct platform_device pdev;
> + char name[sizeof(FIXED_NAME)];

So, this looks pretty ugly and doesn't seem terribly directly related to
supplying a voltage parameter. Please split it out into a separate
change.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-06-18 12:21    [from the cache]
©2003-2011 Jasper Spaans