lkml.org 
[lkml]   [2012]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()
    > extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
    > kfree(info->edev) here.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>

    The patch is correct.

    However, using devm_kzalloc at probe and removing kfree at remove appears to be much better.

    Thank you.


    Cheers!
    MyungJoo.

    > ---
    > drivers/extcon/extcon-max8997.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
    > index 5ecf176..a4ed30b 100644
    > --- a/drivers/extcon/extcon-max8997.c
    > +++ b/drivers/extcon/extcon-max8997.c
    > @@ -514,6 +514,7 @@ static int __devexit max8997_muic_remove(struct platform_device *pdev)
    >
    > extcon_dev_unregister(info->edev);
    >
    > + kfree(info->edev);
    > kfree(info);
    >
    > return 0;
    > --
    > 1.7.9.5
    >
    ------
    Sender : Axel Lin<axel.lin@gmail.com>
    Date : 2012-06-16 22:25 (GMT+09:00)
    Title : [PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

    extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
    kfree(info->edev) here.

    Signed-off-by: Axel Lin
    ---
    drivers/extcon/extcon-max8997.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
    index 5ecf176..a4ed30b 100644
    --- a/drivers/extcon/extcon-max8997.c
    +++ b/drivers/extcon/extcon-max8997.c
    @@ -514,6 +514,7 @@ static int __devexit max8997_muic_remove(struct platform_device *pdev)

    extcon_dev_unregister(info->edev);

    + kfree(info->edev);
    kfree(info);

    return 0;
    --
    1.7.9.5






    --
    MyungJoo Ham (함명주), PHD
    System S/W Lab, S/W Platform Team, Software Center
    Samsung Electronics
    Cell: +82-10-6714-2858
    \
     
     \ /
      Last update: 2012-06-18 05:21    [W:0.031 / U:30.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site