Messages in this thread | | | Date | Sat, 16 Jun 2012 13:06:46 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 3.5] c/r: prctl: less paranoid prctl_set_mm_exe_file() |
| |
On Sat, Jun 16, 2012 at 12:51:04PM +0400, Konstantin Khlebnikov wrote: > "no other files mapped" requirement from my previous patch > (c/r: prctl: update prctl_set_mm_exe_file() after mm->num_exe_file_vmas removal) > is too paranoid, it forbids operation even if there mapped one shared-anon vma. > > Let's check that current mm->exe_file already unmapped, in this case exe_file > symlink already outdated and its changing is reasonable. > > Plus, this patch fixes exit code in case operation success. > > Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> > Reported-by: Cyrill Gorcunov <gorcunov@openvz.org> > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: Matt Helsley <matthltc@us.ibm.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Pavel Emelyanov <xemul@parallels.com> > ---
Ack! Thanks again, Konstantin!
Cyrill
| |