lkml.org 
[lkml]   [2012]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: automated warning notifications
[drop sparse developers]

On Sat, Jun 16, 2012 at 03:50:36PM +0800, Cong Wang wrote:
> On Fri, Jun 15, 2012 at 10:34 PM, Fengguang Wu <wfg@linux.intel.com> wrote:
> > On Fri, Jun 15, 2012 at 02:19:14PM +0300, Dan Carpenter wrote:
> >>
> >> Probably we could use something like the attached script to print
> >> out the line of code which causes the bug and some other script to
> >> querry git blame and attach the offending commit?
> >
> > cat -n $code_file | tail -n +$(($lineno - (($context + 1) / 2))) | head -n $(($context + 1))
> >
> > That's handy, I'll use it to show the source file context for the
> > first error/warning :-)
>
> Well, you can use sed/awk, it will be much shorter:
>
> cat -n drivers/leds/led-triggers.c | sed -ne '224,230p'
> 224 struct led_classdev *led_cdev;
> 225
> 226 led_cdev = list_entry(entry, struct led_classdev, trig_list);
> 227 led_set_brightness(led_cdev, brightness);
> 228 }
> 229 read_unlock(&trigger->leddev_list_lock);
> 230 }
>
> (replace the hard-coded "224,230" with a shell variable)

Thanks! I'll use it this way:

lineno=227
context=3
cat -n drivers/leds/led-triggers.c | sed -e "s/ $lineno\t/> $lineno\t/" -ne "$((lineno - context)),$((lineno + context))p"
224 struct led_classdev *led_cdev;
225
226 led_cdev = list_entry(entry, struct led_classdev, trig_list);
> 227 led_set_brightness(led_cdev, brightness);
228 }
229 read_unlock(&trigger->leddev_list_lock);
230 }
> And if you want to find the offending commit:
>
> git show `git blame drivers/leds/led-triggers.c | awk 'NR==227{print $1}'`

The code offered by Peter should run faster:

hash=$(git blame $code_file -L $lineno,$lineno |cut -d " " -f 1)
git --no-pager show $hash $code_file
Anyway, Dan's original idea of using git blame to find out the offending
commit is valuable. The process can be automated like this:

1) use git-blame to find out the commit that changed $lineno in recent 100 days
2) checkout out $commit and build test and check build error
3) checkout out $commit~1 and build test and check build error

If (1) succeeded and (2) got the expected build error while (3) don't
have the build error, we reliably catch the bad commit. Otherwise the
script may try building test other commits that modified the file
recently.
Thanks,
Fengguang


\
 
 \ /
  Last update: 2012-06-16 11:41    [from the cache]
©2003-2011 Jasper Spaans