lkml.org 
[lkml]   [2012]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 06/13] perf: Add Nehalem and Sandy Bridge uncore support
From
Date
On Fri, 2012-06-15 at 14:31 +0800, Yan, Zheng wrote:
> +static struct uncore_event_desc nhm_uncore_events[] = {
> + INTEL_UNCORE_EVENT_DESC(CLOCKTICKS, "config=0xffff"),
> + /* full cache line writes to DRAM */
> + INTEL_UNCORE_EVENT_DESC(QMC_WRITES_FULL_ANY, "event=0x2f,umask=0xf"),
> + /* Quickpath Memory Controller normal priority read requests */
> + INTEL_UNCORE_EVENT_DESC(QMC_NORMAL_READS_ANY, "event=0x2c,umask=0xf"),
> + /* Quickpath Home Logic read requests from the IOH */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_IOH_READS,
> + "event=0x20,umask=0x1"),
> + /* Quickpath Home Logic write requests from the IOH */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_IOH_WRITES,
> + "event=0x20,umask=0x2"),
> + /* Quickpath Home Logic read requests from a remote socket */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_REMOTE_READS,
> + "event=0x20,umask=0x4"),
> + /* Quickpath Home Logic write requests from a remote socket */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_REMOTE_WRITES,
> + "event=0x20,umask=0x8"),
> + /* Quickpath Home Logic read requests from the local socket */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_LOCAL_READS,
> + "event=0x20,umask=0x10"),
> + /* Quickpath Home Logic write requests from the local socket */
> + INTEL_UNCORE_EVENT_DESC(QHL_REQUEST_LOCAL_WRITES,
> + "event=0x20,umask=0x20"),
> + { /* end: all zeroes */ },
> +};

Should we lowercase all event names as well?

/sys/bus/event_source/devices/uncore/events
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_REMOTE_READS
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_LOCAL_READS
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_IOH_READS
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_REMOTE_WRITES
/sys/bus/event_source/devices/uncore/events/QMC_WRITES_FULL_ANY
/sys/bus/event_source/devices/uncore/events/QMC_NORMAL_READS_ANY
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_LOCAL_WRITES
/sys/bus/event_source/devices/uncore/events/QHL_REQUEST_IOH_WRITES
/sys/bus/event_source/devices/uncore/events/CLOCKTICKS

BTW we could encode those things like:

INTEL_UNCORE_EVENT_DESC(qhl_request_local_reads, 0x1020);

And have the print function decode that into something pretty, it would
save some 18 bytes per event or so. Not sure that's worth it, but who
knows.




\
 
 \ /
  Last update: 2012-06-15 20:21    [W:0.575 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site