lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/4] clk: add DT clock binding support
    On Tue, Jun 12, 2012 at 09:41:48AM -0500, Rob Herring wrote:
    > +struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec)
    > +{
    > + struct of_clk_provider *provider;
    > + struct clk *clk = NULL;

    Both clk and clkdev treat NULL as a valid clock and return ERR_PTR for
    error case, while all the codes in this patch just return NULL for
    error and check (clk != NULL) for valid clock.

    Should we force the consistent behavior between DT and non-DT on this?

    > +
    > + /* Check if we have such a provider in our array */
    > + mutex_lock(&of_clk_lock);
    > + list_for_each_entry(provider, &of_clk_providers, link) {
    > + if (provider->node == clkspec->np)
    > + clk = provider->get(clkspec, provider->data);
    > + if (clk)
    > + break;
    > + }
    > + mutex_unlock(&of_clk_lock);
    > +
    > + return clk;
    > +}

    --
    Regards,
    Shawn



    \
     
     \ /
      Last update: 2012-06-15 06:21    [W:3.719 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site