lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -V9 11/15] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup
    On Wed 13-06-12 15:57:30, Aneesh Kumar K.V wrote:
    > From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
    >
    > This patchset add the charge and uncharge routines for hugetlb cgroup.
    > We do cgroup charging in page alloc and uncharge in compound page
    > destructor. Assigning page's hugetlb cgroup is protected by hugetlb_lock.
    >
    > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

    Reviewed-by: Michal Hocko <mhocko@suse.cz>

    One minor comment
    [...]
    > +void hugetlb_cgroup_commit_charge(int idx, unsigned long nr_pages,
    > + struct hugetlb_cgroup *h_cg,
    > + struct page *page)
    > +{
    > + if (hugetlb_cgroup_disabled() || !h_cg)
    > + return;
    > +
    > + spin_lock(&hugetlb_lock);
    > + set_hugetlb_cgroup(page, h_cg);
    > + spin_unlock(&hugetlb_lock);
    > + return;
    > +}

    I guess we can remove the lock here because nobody can see the page yet,
    right?

    --
    Michal Hocko
    SUSE Labs
    SUSE LINUX s.r.o.
    Lihovarska 1060/12
    190 00 Praha 9
    Czech Republic


    \
     
     \ /
      Last update: 2012-06-14 12:01    [W:4.102 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site