Messages in this thread | | | Date | Wed, 13 Jun 2012 09:38:46 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support |
| |
* Stephane Eranian <eranian@google.com> wrote:
> > Peter suggests keeping the uncore names as they're listed in > > the intel doc. For Sandybirdge-EP, uncore names are > > something like: Cbo, iMC, QPI. I think Uncore_Cbo_0 appears > > better than uncore_Cbo_0 > > Keeping the name is different from keeping the upper vs. lower > case letters. I think this need to be case insensitive. What > does it buy you to be case sensitive? Don't think Intel is > ever going to create two events which differ only by the lower > vs. upper case. And, I think that's extra frustration when you > type the event name because you have to also remember the > letter case.
Yeah - the right approach is to make it all lowercase in sysfs - then user-space can tolower() the string provided by the user.
There should be no case sensitivity in event specifications anywhere.
Thanks,
Ingo
| |